ci probe: tier-2 config-brand in isolation (do not merge)#2908
ci probe: tier-2 config-brand in isolation (do not merge)#2908ryansolid wants to merge 1 commit into
Conversation
Attribution probe for the #2905 CodSpeed regressions (update1to1 -6.8%, merge -6.8%): each tier-2 patch measured alone against next.
|
size-limit report 📦
|
Coverage Report for CI Build 29616815870Warning No base build found for commit Coverage: 74.74%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Merging this PR will degrade performance by 6.9%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | merge |
165.2 µs | 177.5 µs | -6.9% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing probe/tier2-config-brand (2f7ffea) with next (66a6c13)
CodSpeed attribution (zero-diff control #2906 clean; single-patch probes #2907/#2908/#2909): the config-brand change alone carries merge -7% plus sub-threshold -3..4% across update1to1/propagation — it drove both flagged regressions on this PR. The diff is load-neutral by inspection and byte-flat in an isolated merge harness; the diffuse cross-bench pattern indicates shared-process JIT/IC state redistribution from the hasOverride shape change. Pulled pending a shape-stable redesign (dedicated boolean in the node literal rather than a _config RMW). Remaining: pending-container + ambient-txn, both CodSpeed-clean in isolation. Full 57,073->56,550 min / 21,229->21,050 gz; floor 18,551->18,111 / 7,527->7,376. 1,052 tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Probe served its purpose: guilty — config-brand alone reproduces merge −7% and carries sub-threshold −3..4% on update1to1/propagation (dashboard), making it the driver of both #2905 regressions. The change is load-neutral by inspection and byte-flat in an isolated merge harness; the diffuse cross-bench signature points at shared-process JIT/IC state redistribution from the hasOverride shape change. Pulled from #2905; to be redesigned shape-stably (dedicated boolean in the node creation literal rather than a |
…audit (#2905) * refactor(signals): tier-2 state consolidations from the architecture audit Three behavior-preserving consolidations, each retiring a bug class: - single pending-source container: the _pendingSource/_pendingSources dual representation (singular slot + lazily-promoted Set) collapses to one lazily-created Set; the promotion invariant #2893's first bug broke no longer exists. -267 min / -110 gz. - optimistic brand as CONFIG_OPTIMISTIC bit: deletes OVERRIDE_UNDEFINED and 19 wrap/unwrap sites; the undefined-as-value / undefined-as-brand collision (#2898) is unrepresentable. -123 / -26. - ambient work is a transaction: the globalQueue's parallel batch fields and initTransition's four adoption/aliasing blocks collapse into one always-present batch shape; flush fast-path emptiness check preserved. -270 / -96. Combined: full 57,073->56,413 min / 21,229->21,008 gz; floor 18,551->18,013 / 7,527->7,357. 1,052 tests pass on the integrated branch; each patch was independently verified (byte-exact re-measurement, suite re-run via poison-probed alias configs, hunk-by-hunk behavior review) before integration. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * perf(signals): restore write-path load count with a module-local batch mirror CodSpeed flagged updateSignals:update1to1 at -6.8% on #2905 (reproduced on rerun): queuePendingNode gained a property hop when the batch fields moved behind globalQueue._batch, and it runs once per staged write. A module-local mirror updated at the three _batch assignment sites restores the pristine load count on the write path and commit loop; the field stays authoritative for cross-module readers. The merge bench regression is not yet attributed — this push doubles as the bisection probe: if it persists, it belongs to the pending-container or config-brand change, not the batch consolidation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * revert(signals): pull the config-brand consolidation from this PR CodSpeed attribution (zero-diff control #2906 clean; single-patch probes #2907/#2908/#2909): the config-brand change alone carries merge -7% plus sub-threshold -3..4% across update1to1/propagation — it drove both flagged regressions on this PR. The diff is load-neutral by inspection and byte-flat in an isolated merge harness; the diffuse cross-bench pattern indicates shared-process JIT/IC state redistribution from the hasOverride shape change. Pulled pending a shape-stable redesign (dedicated boolean in the node literal rather than a _config RMW). Remaining: pending-container + ambient-txn, both CodSpeed-clean in isolation. Full 57,073->56,550 min / 21,229->21,050 gz; floor 18,551->18,111 / 7,527->7,376. 1,052 tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Single-patch attribution probe for #2905's CodSpeed regressions. Zero-diff probe (#2906) came back clean, so the regressions are real; this measures the
config-brandconsolidation alone. Will close after CodSpeed reports.🤖 Generated with Claude Code